Allow alternate nodejs binaries #7405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Delegating to @blorente , who is going to be looking at some other nodes.js stuff this week. |
cosmicexplorer
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
This is great! I've been meaning to do this for each of our no-op scripts in https://github.com/pantsbuild/binaries but haven't gotten around to it. I'm pretty enthusiastic about this, it's not clear that other build tools decide that reliably providing specific versions of the tools they rely on is part of their purview and avoiding having to re-provision your laptop/CI environment for every single tool you want to use is part of why I want to write build tools in the first place.
blorente
approved these changes
Mar 21, 2019
codealchemy
force-pushed
the
node-alt-binary
branch
2 times, most recently
from
f0bad1a
to
6aee5f4
Compare
The binary is extracted into a directory following the naming of the version and system id (ex. node-v8.11.3-darwin-x64)
codealchemy
force-pushed
the
node-alt-binary
branch
from
6aee5f4
to
f79ea33
Compare
stuhood
pushed a commit
that referenced
this pull request
Aug 13, 2019
### Problem (and solution) Same as #7405 [Slack thread](https://pantsbuild.slack.com/archives/C046T6T9U/p1565633047078400) that highlighted this issue. ### Result Users can now use any supported `yarn` release. Related `binaries` repo script for building yarn [`here`](https://github.com/pantsbuild/binaries/blob/master/build-yarnpkg.sh).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Attempting to use the latest node LTS (10.15.3 - the latest LTS released March 5th) fails to install in
pantsas it seems the binary is not inpants' s3 - as seen in the error returned bypants:The issue of binaries in s3 has come up before in another context (the motivation there was related to bandwidth costs, not unavailable binaries), and a solution was implemented for
goandllvmin #5780.Solution
This continues the work done in the #5780, leveraging the
BinaryToolUrlGeneratorto allow node binaries to be fetched fromnodejs.org(see full list of binaries for the latest LTS release here).Result
Users can now use any supported node release from
nodejs.org- verified locally (on a Mac using the latest LTS)